Skip to content

Conversation

juniper-shopify
Copy link
Contributor

@juniper-shopify juniper-shopify commented Oct 9, 2025

Add type annotations for Roast::DSL::Executor

This PR adds type annotations for Roast::DSL::Executor.

  • Moved @cogs and @cog_stack instance variable initializations to initialize to allow them to be non-nilable
  • Moved @config_context and @execution_context to initialize to alllow them to be explicitly set as nillable but also not confuse sorbet that they are not nil where they are actually set.
  • Made extract_dsl_procs! method private

@juniper-shopify juniper-shopify changed the title Add type annotations and fix Graph cog initialization Add type annotations for executor Oct 9, 2025
@juniper-shopify juniper-shopify changed the title Add type annotations for executor Add type annotations for Executor Oct 9, 2025
@juniper-shopify juniper-shopify changed the title Add type annotations for Executor Add type annotations for Roast::DSL::Executor Oct 9, 2025
@juniper-shopify juniper-shopify marked this pull request as ready for review October 9, 2025 21:50
@juniper-shopify juniper-shopify force-pushed the juni/10-09-add_type_annotations_for_executor branch from 2fd90b4 to ba29d0c Compare October 10, 2025 03:32
@juniper-shopify juniper-shopify force-pushed the juni/10-09-alphabetize_gemfile branch from bcad137 to 23ad906 Compare October 10, 2025 03:32
@juniper-shopify juniper-shopify force-pushed the juni/10-09-add_type_annotations_for_executor branch from ba29d0c to b0e8781 Compare October 10, 2025 14:04
@juniper-shopify juniper-shopify force-pushed the juni/10-09-add_type_annotations_for_executor branch from b0e8781 to c49560a Compare October 14, 2025 00:35
@juniper-shopify juniper-shopify force-pushed the juni/10-09-alphabetize_gemfile branch from 23ad906 to 8730b67 Compare October 14, 2025 00:35
@juniper-shopify juniper-shopify changed the base branch from juni/10-09-alphabetize_gemfile to graphite-base/426 October 14, 2025 01:03
@juniper-shopify juniper-shopify force-pushed the juni/10-09-add_type_annotations_for_executor branch from c49560a to 09b851f Compare October 14, 2025 01:04
@graphite-app graphite-app bot changed the base branch from graphite-base/426 to main October 14, 2025 01:04
@juniper-shopify juniper-shopify force-pushed the juni/10-09-add_type_annotations_for_executor branch from 09b851f to 37da2e6 Compare October 14, 2025 01:04
@juniper-shopify juniper-shopify merged commit a88e5cf into main Oct 14, 2025
8 checks passed
Copy link
Contributor Author

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants