-
Notifications
You must be signed in to change notification settings - Fork 52
Add type annotations for Roast::DSL::Executor #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
juniper-shopify
merged 1 commit into
main
from
juni/10-09-add_type_annotations_for_executor
Oct 14, 2025
Merged
Add type annotations for Roast::DSL::Executor #426
juniper-shopify
merged 1 commit into
main
from
juni/10-09-add_type_annotations_for_executor
Oct 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2fd90b4
to
ba29d0c
Compare
bcad137
to
23ad906
Compare
This was referenced Oct 10, 2025
ba29d0c
to
b0e8781
Compare
dersam
reviewed
Oct 10, 2025
b0e8781
to
c49560a
Compare
23ad906
to
8730b67
Compare
8730b67
to
3c1bad1
Compare
c49560a
to
09b851f
Compare
09b851f
to
37da2e6
Compare
dersam
approved these changes
Oct 14, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type annotations for Roast::DSL::Executor
This PR adds type annotations for Roast::DSL::Executor.
@cogs
and@cog_stack
instance variable initializations toinitialize
to allow them to be non-nilable@config_context
and@execution_context
toinitialize
to alllow them to be explicitly set as nillable but also not confuse sorbet that they are not nil where they are actually set.extract_dsl_procs!
method private