Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path.interpolate signature #567

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Fix path.interpolate signature #567

merged 3 commits into from
Jun 13, 2022

Conversation

wcandillon
Copy link
Contributor

Update the interpolate return type to be more consistent with other path methods.

@wcandillon wcandillon requested a review from chrfalch June 11, 2022 10:55
@wcandillon wcandillon self-assigned this Jun 11, 2022
@@ -53,7 +53,7 @@ export const AnimateTextOnPath = () => {
// Create a derived value that interpolates between
// the start and end path
const path = useDerivedValue(
() => path1.interpolate(path2, progress.current),
() => path1.interpolate(path2, progress.current)!,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These null assertion operator may feel annoying but we have interpolatePaths coming in another PR ;-)

Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@wcandillon wcandillon merged commit b3598b4 into main Jun 13, 2022
@wcandillon wcandillon deleted the fix/path-interpolate branch June 13, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants