Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up setInterval #421

Merged
merged 8 commits into from
Apr 22, 2022
Merged

Clean up setInterval #421

merged 8 commits into from
Apr 22, 2022

Conversation

wcandillon
Copy link
Contributor

I noticed it was running if you go back to the previous screen

@wcandillon wcandillon self-assigned this Apr 21, 2022
chrfalch
chrfalch suggested changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove commented out onPress
  • We should change the text <Text>Touch graph to interpolate</Text> to something like <Text>Animating changed paths</Text> (or something)! :)

example/src/Examples/Graphs/Interpolation.tsx Outdated Show resolved Hide resolved
@wcandillon
Copy link
Contributor Author

done!

chrfalch
chrfalch approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@chrfalch chrfalch merged commit 705d977 into main Apr 22, 2022
@chrfalch chrfalch deleted the fix/example-clean-up branch April 22, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcandillon @chrfalch