Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle symlink error when copying files from cpp to android/cpp #40

Merged
merged 5 commits into from
Dec 22, 2021

Conversation

NikitaDudin
Copy link
Contributor

@NikitaDudin NikitaDudin commented Dec 18, 2021

Description

Faced with symlink error after run cd package && yarn

err

Linked issues

@ghost ghost added the cla-needed label Dec 18, 2021
@UnknownH
Copy link

A valid solution should probably destroy the existing symlinks if they exist, and thus clean the way for the rest of the script to operate as usual creating new ones, since for example the currently versioned *nix style symlinks won't work on Windows.

@NikitaDudin NikitaDudin changed the title Handle symlink error when copiyng files from cpp to android/cpp Handle symlink error when copying files from cpp to android/cpp Dec 19, 2021
Copy link
Contributor

@samuel-rl samuel-rl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple request changes, but I approve

package/scripts/install-npm.js Outdated Show resolved Hide resolved
package/scripts/install-npm.js Outdated Show resolved Hide resolved
@chrfalch chrfalch linked an issue Dec 22, 2021 that may be closed by this pull request
@chrfalch chrfalch merged commit e563eb9 into Shopify:main Dec 22, 2021
@chrfalch
Copy link
Contributor

Thanks @NikitaDudin !! Really appreciate your help 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with the example projects
4 participants