Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❄️ Freeze Drawing #396

Merged
merged 7 commits into from
Apr 20, 2022
Merged

❄️ Freeze Drawing #396

merged 7 commits into from
Apr 20, 2022

Conversation

wcandillon
Copy link
Contributor

fixes #395

Converts a drawing to an Image. The performance improvement can see at https://www.dropbox.com/s/nvehwch3eenqa2b/demo.mov?dl=0
This is useful when having a complex canvas and you want only the animated parts to be redrawn on each frame.

In parallel of this, we are working on a performance improvement that will remove the need to use such a component for a picture that has a lot of simple drawing commands. For pictures that have few drawing commands that are complex (inner shadows on paths and other image filters), this component will still be very handy.

@wcandillon wcandillon marked this pull request as ready for review April 13, 2022 05:58
@wcandillon wcandillon changed the title ❄️ ImageDrawing ❄️ Freeze Drawing Apr 13, 2022
@wcandillon wcandillon self-assigned this Apr 13, 2022
@chrfalch
Copy link
Contributor

Awesome work. I’m trying to do some thinking about this one and will test it during the weekend!

@chrfalch chrfalch merged commit 2cad8c5 into main Apr 20, 2022
@chrfalch chrfalch deleted the feat/freeze branch April 20, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance issues when applying a transform to a Group with many children.
2 participants