enable C++17 for iOS build #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfalch
reviewed
Apr 6, 2022
| @@ -61,7 +61,7 @@ - (void) willMoveToWindow:(UIWindow *)newWindow { | |||
| } else { | |||
| // Create implementation view when the parent view is set | |||
| if(_impl == nullptr && _manager != nullptr) { | |||
| __weak typeof(self) weakSelf = self; | |||
| __weak decltype(self) weakSelf = self; | |||
There was a problem hiding this comment.
Nice catch! Was looking into this one after I started building against Fabric earlier today!!!
There was a problem hiding this comment.
@chrfalch did you manage to build project for Fabric?
chrfalch
approved these changes
Apr 6, 2022
does not rely on GNU extensions, instead use standardized C++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #305