Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify SkiaView #285

Merged
merged 2 commits into from
Mar 24, 2022
Merged

simplify SkiaView #285

merged 2 commits into from
Mar 24, 2022

Conversation

schiller-manuel
Copy link
Contributor

  • store nativeId as number, only convert to string when necessary
  • only call setDrawCallback once

@schiller-manuel
simplify SkiaView
b347be0 
* store nativeId as number, only convert to string when necessary
* only call `setDrawCallback` once
@wcandillon
Copy link
Contributor

Thanks for the PR, the string nativeId thingy also came up previously.

chrfalch
chrfalch approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@chrfalch chrfalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@chrfalch chrfalch merged commit ce08dc7 into Shopify:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schiller-manuel @wcandillon @chrfalch