Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐎 Consolidate Spring function #269

Merged
merged 6 commits into from
Mar 23, 2022
Merged

🐎 Consolidate Spring function #269

merged 6 commits into from
Mar 23, 2022

Conversation

wcandillon
Copy link
Contributor

@wcandillon wcandillon commented Mar 17, 2022 •
edited
Loading

The goal of this PR is to consolidate the spring function by:

  • Allowing to pass spring parameters directly
  • Remove knowledge of the spring function within the timing functions

cc @mrousavy

@wcandillon wcandillon mentioned this pull request Mar 17, 2022
Closed
@wcandillon wcandillon changed the title 🏗 Consolidate Spring function 🐎 Consolidate Spring function Mar 17, 2022
@wcandillon wcandillon self-assigned this Mar 17, 2022
@chrfalch chrfalch merged commit 9196c09 into main Mar 23, 2022
@chrfalch chrfalch deleted the fix/spring-signature branch March 23, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrfalch chrfalch chrfalch approved these changes

Assignees

@wcandillon wcandillon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcandillon @chrfalch