Protect nilable procs with parenthesis when translating to RBS #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
approved these changes
Jan 15, 2025
vinistock
approved these changes
Jan 15, 2025
lib/rbi/rbs_printer.rb
Outdated
| @@ -885,7 +885,13 @@ def visit_attached_class(type) | |||
|
|
|||
| sig { params(type: Type::Nilable).void } | |||
| def visit_nilable(type) | |||
| if type.type.is_a?(Type::Proc) | |||
There was a problem hiding this comment.
NIT: We're repeating type.type 3 times. Can we pull it into a local and reuse?
There was a problem hiding this comment.
Extracted in local variable inner 👍
Morriar
force-pushed
the
at-rbs-nilable-procs
branch
2 times, most recently
from
83ad5b6 to
0614069
Compare
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-rbs-nilable-procs
branch
from
0614069 to
08b26c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When translating this RBI signature:
We need to put the proc into parenthesis to keep the current semantics:
Otherwise we end up with the return type of the block being nilable rather than the proc itself: