Handle spaces in types during RBS translation #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
approved these changes
Jan 14, 2025
vinistock
approved these changes
Jan 15, 2025
test/rbi/parser_test.rb
Outdated
| RBI | ||
|
|
||
| tree = parse_rbi(rbi) | ||
| puts tree.string |
There was a problem hiding this comment.
Nice catch, thanks!
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-rbs-spaces
branch
from
7b30b1c to
89afbcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found some signatures formatted as follow:
While this is valid in Ruby/RBI, having spaces or new lines in a type is a syntax error in RBS.