Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBS translation of shape string keys #392

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix RBS translation of shape string keys #392

merged 1 commit into from
Jan 15, 2025

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jan 14, 2025

Before this change all shape keys were always translated as symbol, this change makes it possible to use string keys in shapes.

So this RBI signature:

sig { returns({a: A, "b": B, :c => C, "d" => D}) }
def foo; end

Is properly translated as:

def foo: -> {a: A, b: B, c: C, "d" => D}

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the bugfix Fix a bug label Jan 14, 2025
@Morriar Morriar self-assigned this Jan 14, 2025
@Morriar Morriar requested a review from a team as a code owner January 14, 2025 20:19
@Morriar Morriar merged commit 66af789 into main Jan 15, 2025
8 checks passed
@Morriar Morriar deleted the at-rbs-records branch January 15, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants