Merge pull request #394 from Shopify/at-rbs-block-alias

Fix RBS translation of non-block type in block position
Shopify · Jan 15, 2025 · 3ac48c6 · 3ac48c6
2 parents 7a93edf + 4aa8d30
commit 3ac48c6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/lib/rbi/rbs_printer.rb b/lib/rbi/rbs_printer.rb
@@ -396,9 +396,7 @@ def print_method_sig(node, sig)
           type_string = "(?) -> untyped"
           block_is_nilable = true
         when Type::Simple
-          if block_type.name == "Proc"
-            type_string = "(?) -> untyped"
-          end
+          type_string = "(?) -> untyped"
           skip = true if block_type.name == "NilClass"
         end
 

diff --git a/test/rbi/rbs_printer_test.rb b/test/rbi/rbs_printer_test.rb
@@ -575,6 +575,21 @@ def d: -> {a: A, "B-B": B}
       RBI
     end
 
+    def test_print_block_type_alias
+      rbi = parse_rbi(<<~RBI)
+        BLOCK = T.type_alias { T.proc.void }
+
+        sig { params(block: BLOCK) }
+        def foo(&block); end
+      RBI
+
+      assert_equal(<<~RBI, rbi.rbs_string)
+        BLOCK: untyped
+
+        def foo: { (?) -> untyped } -> void
+      RBI
+    end
+
     def test_print_t_structs
       rbi = parse_rbi(<<~RBI)
         class Foo < T::Struct; end