Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of Element.getchildren() #38

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Remove the use of Element.getchildren() #38

merged 1 commit into from
Feb 2, 2021

Conversation

smubbs
Copy link
Contributor

@smubbs smubbs commented Dec 2, 2020

Removes the use of Element.getchildren() as this will be removed in Python 3.9

Fixes:
#37

mllemango
mllemango approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@mllemango mllemango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks great!

@mllemango mllemango merged commit c3af1e9 into Shopify:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mllemango mllemango mllemango approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smubbs @mllemango