[Banner updates] Fix content horizontal stack #9360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
approved these changes
Jun 2, 2023
polaris-react/src/components/Banner/components/BannerExperimental/BannerExperimental.tsx
Outdated
Show resolved
Hide resolved
sophschneider
force-pushed
the
sophie/banner-content-fix
branch
from
f41a765 to
3d1f3ee
Compare
kyledurand
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Before, children nodes were horizontally stacking since they were a child of a horizontal stack. This wraps
childrenin aBoxto keep the multi node children styled consistently. I also added stories for content links which is a common multi children node pattern to pass into theBanner.WHAT is this pull request doing?
How to 🎩
🎩 checklist