Skip to content

Add All stories for Badge, Banner, and KeyboardKey #9352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add All stories for Badge, Banner, and KeyboardKey #9352

merged 1 commit into from
Jun 1, 2023

Conversation

@sophschneider
Copy link
Contributor

WHAT is this pull request doing?

  • Add All stories for Badge, Banner, and KeyboardKey
  • Fix :where specificity in Badge styles
  • Fix keyboard key uppercase in default variant to match small variant

@sophschneider sophschneider requested review from a team and kyledurand June 1, 2023 20:20
kyledurand
kyledurand approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I sort of expected to see code moved rather than just added to fix the specificity issue.

@sophschneider sophschneider merged commit 11dea74 into v11.x.x Jun 1, 2023
@sophschneider sophschneider deleted the sophie/where-updates branch June 1, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyledurand kyledurand kyledurand approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sophschneider @kyledurand