Add new spacing / border tokens and aliases #9322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm adding new border tokens here as well since they're also decimal related |
kyledurand
changed the title
kyledurand
changed the title
There was a problem hiding this comment.
Looks good so far 👍 Can we continue prefixing all net new tokens with experimental? With our current approach, these beta flagged tokens will be globally accessible and I think it's important we clearly communicate and distinguish the tokens we just documented/rolled out across the org from those temporarily living side by side the current system (additionally allowing us to freely make breaking changes). We should be able to follow the pattern established in the color token group everywhere and migrate tokens to any naming convention in the future.
sarahill
approved these changes
May 31, 2023
aaronccasanova
approved these changes
May 31, 2023
|
@kyledurand we no longer need the |
kyledurand
force-pushed
the
add-new-space-token
branch
from
17d1390 to
7d0b80b
Compare
sophschneider
pushed a commit
that referenced
this pull request
Jun 1, 2023
### WHY are these changes introduced? Fixes Shopify/archive-polaris-backlog-2024#70 Fixes Shopify/archive-polaris-backlog-2024#69 Couple of options here, and I don't love this one but I figured I'd put the exploration up anyway. We need a value of 6px which would mean a token 1.5. Our current naming convention doesn't really support adding a decimal value that isn't zero trailing. i.e. we have space-05 representing 0.5 but space-15 would mean something completely different. This adds underscore aliases to decimal values that already exist and also adds a value for `space-1_5` The other option, since this is a one off would just be to use calc() to get 6px out of the current tokens but we'll still need a decimal solution for borders
sophschneider
pushed a commit
that referenced
this pull request
Jun 1, 2023
### WHY are these changes introduced? Fixes Shopify/archive-polaris-backlog-2024#70 Fixes Shopify/archive-polaris-backlog-2024#69 Couple of options here, and I don't love this one but I figured I'd put the exploration up anyway. We need a value of 6px which would mean a token 1.5. Our current naming convention doesn't really support adding a decimal value that isn't zero trailing. i.e. we have space-05 representing 0.5 but space-15 would mean something completely different. This adds underscore aliases to decimal values that already exist and also adds a value for `space-1_5` The other option, since this is a one off would just be to use calc() to get 6px out of the current tokens but we'll still need a decimal solution for borders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-summer-editions/issues/70
Fixes https://github.com/Shopify/polaris-summer-editions/issues/69
Couple of options here, and I don't love this one but I figured I'd put the exploration up anyway.
We need a value of 6px which would mean a token 1.5. Our current naming convention doesn't really support adding a decimal value that isn't zero trailing. i.e. we have space-05 representing 0.5 but space-15 would mean something completely different.
This adds underscore aliases to decimal values that already exist and also adds a value for
space-1_5The other option, since this is a one off would just be to use calc() to get 6px out of the current tokens but we'll still need a decimal solution for borders