Add experimental to colour aliases
#9312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
force-pushed
the
sophie/tokens-experimental
branch
from
67bdac9 to
5137586
Compare
sophschneider
changed the title
sophschneider
commented
May 27, 2023
| | 'bg-transparent-active' | ||
| | 'bg-inverse-transparent-hover' | ||
| | 'bg-inverse-transparent-active'; | ||
| | 'experimental-subdued-link' |
There was a problem hiding this comment.
I didn't extract this in the ColorTextAlias because i'm not sure if its a text token
There was a problem hiding this comment.
I think this was added as more of a test to make sure the new tokens were being generated properly. If it's not used we can remove it for now, rename ColorExperimentalAlias to ColorExperimentalBackgroundAlias and remove the extract above which I think would be cleaner. We'll add another group for experimental text colors when they're ready in figma
sophschneider
changed the title
experimental to colour aliases
kyledurand
approved these changes
May 29, 2023
| | 'bg-transparent-active' | ||
| | 'bg-inverse-transparent-hover' | ||
| | 'bg-inverse-transparent-active'; | ||
| | 'experimental-subdued-link' |
There was a problem hiding this comment.
I think this was added as more of a test to make sure the new tokens were being generated properly. If it's not used we can remove it for now, rename ColorExperimentalAlias to ColorExperimentalBackgroundAlias and remove the extract above which I think would be cleaner. We'll add another group for experimental text colors when they're ready in figma
sophschneider
force-pushed
the
sophie/tokens-experimental
branch
from
c8024f3 to
def7e5e
Compare
sophschneider
added a commit
that referenced
this pull request
Jun 1, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? prefixing the `experimental` keyword on the color Aliases allows us to use the experimental tokens where the Alias types are used. For example, on the [Box component](https://polaris.shopify.com/components/layout-and-structure/box) you could now use the experimental tokens as a background without type errors. ``` <Box background={'experimental-bg-input-hover'} /> ```
sophschneider
added a commit
that referenced
this pull request
Jun 1, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? prefixing the `experimental` keyword on the color Aliases allows us to use the experimental tokens where the Alias types are used. For example, on the [Box component](https://polaris.shopify.com/components/layout-and-structure/box) you could now use the experimental tokens as a background without type errors. ``` <Box background={'experimental-bg-input-hover'} /> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
prefixing the
experimentalkeyword on the color Aliases allows us to use the experimental tokens where the Alias types are used. For example, on the Box component you could now use the experimental tokens as a background without type errors.