- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Add new transparency tokens #9296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9743f53    to
    92286f0      
    Compare
  
    92286f0    to
    29587f4      
    Compare
  
    e58ddd7    to
    f108f2d      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sufficient starting point for applying alpha values to the gray palette and unblocking beta overrides. I'm not sure the pattern is very scalable as we'd likely have to update each shade to a function that returns an rgba to establish a convention and consistency.
Two approaches I would like to see explored is a simple toRgba util that updates the alpha (e.g. toRgba(gray[2], 0.5)) or breaking up palette colors into two parts (e.g. a grayParts object with rgb values and a gray object using the parts and applying alpha).
Since accessing these tokens in JS or the build assets is always a key/value pair, I think we are fine to proceed with this strategy and update to the above or something else in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good as a first/quick solution. Agree with Aaron that this could be further optimized but let's ship this now and come back to it 💯 🚢
| Yeah, now that we have a transparency theme we need the system to be more flexible at scale, agreed. This means a system change at some point but for now this works within the current system | 
This adds the ability to generate gray tokens with alpha values for the new transparency subset
This adds the ability to generate gray tokens with alpha values for the new transparency subset
This adds the ability to generate gray tokens with alpha values for the new transparency subset
This adds the ability to generate gray tokens with alpha values for the new transparency subset