Skip to content

Conversation

@kyledurand
Copy link
Member

Previous selector had a specificity of (0,2,1) meaning it would be fairly difficult to override. The new value is (0,1,0)

Before

After

Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
@kyledurand kyledurand requested a review from aaronccasanova May 25, 2023 19:17
Copy link
Member

@aaronccasanova aaronccasanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can we also accompany this with the @shopify/polaris-tokens :root and :root:where(.flag) change?

@kyledurand kyledurand merged commit 7fbc882 into v11.x.x May 25, 2023
@kyledurand kyledurand deleted the less-specific-global-selector branch May 25, 2023 20:29
sam-b-rose pushed a commit that referenced this pull request May 26, 2023
Previous selector had a specificity of (0,2,1) meaning it would be
fairly difficult to override. The new value is (0,1,0)


[Before](https://polypane.app/css-specificity-calculator/#selector=html%5Bclass*%3D'Polaris-Summer-Editions-2023'%5D%20.Link)


[After](https://polypane.app/css-specificity-calculator/#selector=%3Awhere(html%5Bclass*%3D'Polaris-Summer-Editions-2023'%5D)%20.Link)

---------

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
sophschneider pushed a commit that referenced this pull request Jun 1, 2023
Previous selector had a specificity of (0,2,1) meaning it would be
fairly difficult to override. The new value is (0,1,0)


[Before](https://polypane.app/css-specificity-calculator/#selector=html%5Bclass*%3D'Polaris-Summer-Editions-2023'%5D%20.Link)


[After](https://polypane.app/css-specificity-calculator/#selector=%3Awhere(html%5Bclass*%3D'Polaris-Summer-Editions-2023'%5D)%20.Link)

---------

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
sophschneider pushed a commit that referenced this pull request Jun 1, 2023
Previous selector had a specificity of (0,2,1) meaning it would be
fairly difficult to override. The new value is (0,1,0)


[Before](https://polypane.app/css-specificity-calculator/#selector=html%5Bclass*%3D'Polaris-Summer-Editions-2023'%5D%20.Link)


[After](https://polypane.app/css-specificity-calculator/#selector=%3Awhere(html%5Bclass*%3D'Polaris-Summer-Editions-2023'%5D)%20.Link)

---------

Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants