[AppProvider] Fix storybook context #9264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
approved these changes
May 24, 2023
size-limit report 📦
|
gwyneplaine
added a commit
that referenced
this pull request
May 25, 2023
Remerging #9264 into v11.x.x to fix bad rebase Co-authored-by: kyledurand <kyle.durand@shopify.com>
yurm04
pushed a commit
that referenced
this pull request
May 25, 2023
Some stories with app provider weren't toggling the global class properly. This passes in the correct context and also fixes a type error with the useFeatures import This was causing some false positives with chromatic
sam-b-rose
pushed a commit
that referenced
this pull request
May 26, 2023
Remerging #9264 into v11.x.x to fix bad rebase Co-authored-by: kyledurand <kyle.durand@shopify.com>
sophschneider
pushed a commit
that referenced
this pull request
Jun 1, 2023
Remerging #9264 into v11.x.x to fix bad rebase Co-authored-by: kyledurand <kyle.durand@shopify.com>
sophschneider
pushed a commit
that referenced
this pull request
Jun 1, 2023
Remerging #9264 into v11.x.x to fix bad rebase Co-authored-by: kyledurand <kyle.durand@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stories with app provider weren't toggling the global class properly. This passes in the correct context and also fixes a type error with the useFeatures import
This was causing some false positives with chromatic