- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Add experimental colors #9241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental colors #9241
Conversation
8bb7a5a    to
    dd5cb14      
    Compare
  
    | size-limit report 📦
 | 
dd5cb14    to
    5788197      
    Compare
  
    | Discussed offline and brainstormed a consolidated strategy for rolling out experimental tokens: 0869b42 
 
 Example of new tokens that do NOT map to an existing alias: Example of new tokens that map to an existing alias (overridden via beta flag) | 
| /snapit | 
| 🫰✨ Thanks @kyledurand! Your snapshots have been published to npm. Test the snapshots by updating your  yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230523201101yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230523201101yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230523201101yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230523201101yarn add @shopify/polaris@0.0.0-snapshot-release-20230523201101yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230523201101yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230523201101 | 
### WHY are these changes introduced? ### WHAT is this pull request doing? Adds a bit of experimental coloring <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Remerging #9241 into v11.x.x to fix bad rebase --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Remerging #9241 into v11.x.x to fix bad rebase --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Remerging #9241 into v11.x.x to fix bad rebase --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Remerging #9241 into v11.x.x to fix bad rebase --------- Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: kyledurand <kyle.durand@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>


WHY are these changes introduced?
WHAT is this pull request doing?
Adds a bit of experimental coloring
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes