Add new token group "space" to replace spacing in v11 #9016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
alex-page
force-pushed
the
rename-spacing-to-space
branch
from
e98ddc2 to
22aa54a
Compare
alex-page
changed the title
alex-page
changed the title
alex-page
force-pushed
the
rename-spacing-to-space
branch
from
d649b88 to
244c643
Compare
lgriffee
reviewed
Apr 19, 2023
lgriffee
reviewed
Apr 19, 2023
lgriffee
approved these changes
Apr 19, 2023
|
|
alex-page
commented
Apr 20, 2023
polaris.shopify.com/content/tools/stylelint-polaris/rules/space-global-disallowed-list.md
Outdated
Show resolved
Hide resolved
…e-global-disallowed-list.md
|
Going to add a redirect for the new polaris.shopify.com page in |
|
Oh we also need redirects for all the stylelint pages! Going to add that too before this ships 👍🏻 |
|
Redirects aren't working in localhost. Looks like I forgot to add the new groups. Don't ship this yet. |
aaronccasanova
approved these changes
Apr 20, 2023
|
Fixed the redirects so they work on localhost! Also it looks like anchor link redirects don't work so I removed it. |
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
- [x] Update polaris.shopify.com docs - [x] Add new token group `space` - [x] Update types to remove `Spacing` and duplicate `SpacingSpace` - [x] Replace usage of `spacing` with `space` in tsx - [x] Does not touch scss as the token names are the exact same --------- Co-authored-by: Laura Griffee <laura@mailzone.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
- [x] Update polaris.shopify.com docs - [x] Add new token group `space` - [x] Update types to remove `Spacing` and duplicate `SpacingSpace` - [x] Replace usage of `spacing` with `space` in tsx - [x] Does not touch scss as the token names are the exact same --------- Co-authored-by: Laura Griffee <laura@mailzone.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spaceSpacingand duplicateSpacingSpacespacingwithspacein tsx