Skip to content

[Tooltip] Tweak animation duration and box-shadow #8629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 14, 2023
Merged

[Tooltip] Tweak animation duration and box-shadow #8629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c7e1a6
chore: tweak animation time and shadow of tooltip overlay
mrcthms Mar 9, 2023
7262e91
chore: update shadow value
mrcthms Mar 10, 2023
6a79576
chore: add changeset
mrcthms Mar 10, 2023
e554dc4
chore: use shadow-lg
mrcthms Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-plums-shout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Updated the animation duration and box-shadow for the `Tooltip`
2 changes: 1 addition & 1 deletion polaris-react/src/components/Tooltip/Tooltip.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export function ActivatorAsDiv() {

export function WithSuffix() {
return (
<Box padding="16">
<Box padding="16" background="surface">
<LegacyStack>
<ButtonGroup segmented fullWidth>
<Tooltip content="Bold" suffix="⌘B" activatorWrapper="div">
Expand Down
6 changes: 3 additions & 3 deletions polaris-react/src/components/Tooltip/components/TooltipOverlay/TooltipOverlay.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
margin: var(--pc-tooltip-overlay-offset) var(--p-space-4) var(--p-space-4);
opacity: 1;
box-shadow: var(--p-shadow-popover);
box-shadow: var(--p-shadow-popover), var(--p-shadow-lg);
// stylelint-disable-next-line -- Polaris component custom properties
border-radius: var(--pc-tooltip-border-radius);
pointer-events: none;
Expand Down Expand Up @@ -48,7 +48,7 @@
}

.measured:not(.instant) {
animation: var(--p-keyframes-appear-below) var(--p-duration-200)
animation: var(--p-keyframes-appear-below) var(--p-duration-50)
var(--p-ease-in) var(--p-duration-100) 1 both;

// stylelint-disable-next-line -- Not a breakpoint
Expand All @@ -58,7 +58,7 @@
}

.measured.positionedAbove:not(.instant) {
animation: var(--p-keyframes-appear-above) var(--p-duration-200)
animation: var(--p-keyframes-appear-above) var(--p-duration-50)
var(--p-ease-in) var(--p-duration-100) 1 both;

// stylelint-disable-next-line -- Not a breakpoint
Expand Down