Skip to content

fix small layout bugs in app-settings-layout code example #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023
Merged

fix small layout bugs in app-settings-layout code example #8622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af62870
fix small layout bugs in app-settings-layout code example
gwyneplaine Mar 10, 2023
8d0f8dd
changeset
gwyneplaine Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/few-files-drop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'polaris.shopify.com': patch
---

Fix minor layout bugs in app-settings-layout pattern code example
22 changes: 11 additions & 11 deletions polaris.shopify.com/content/patterns/app-settings-layout/variants/default.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,19 +46,19 @@ This pattern uses the [`AlphaStack`](/components/layout-and-structure/alpha-stac
]}
>
<AlphaStack gap="16" align="center">
<Columns columns={{xs: '1fr', md: '2fr 5fr'}}>
<Columns columns={{xs: '1fr', md: '2fr 5fr'}} gap="4">
<Box
as="section"
paddingInlineStart={{xs: 4, sm: 0}}
paddingInlineEnd={{xs: 2, sm: 0}}
paddingInlineEnd={{xs: 4, sm: 0}}
>
<AlphaStack align="start" gap="4">
<AlphaStack gap="4">
<Text as="h3" variant="headingMd">
InterJambs
</Text>
<p>
<Text as="p" variant="bodyMd">
Interjambs are the rounded protruding bits of your puzzlie piece
</p>
</Text>
</AlphaStack>
</Box>
<AlphaCard roundedAbove="sm">
Expand All @@ -68,19 +68,19 @@ This pattern uses the [`AlphaStack`](/components/layout-and-structure/alpha-stac
</AlphaStack>
</AlphaCard>
</Columns>
<Columns columns={{xs: '1fr', md: '2fr 5fr'}}>
<Columns columns={{xs: '1fr', md: '2fr 5fr'}} gap="4">
<Box
as="section"
paddingInlineStart={{xs: 2, sm: 0}}
paddingInlineEnd={{xs: 2, sm: 0}}
paddingInlineStart={{xs: 4, sm: 0}}
paddingInlineEnd={{xs: 4, sm: 0}}
>
<AlphaStack align="start" gap="4">
<AlphaStack gap="4">
<Text as="h3" variant="headingMd">
Dimensions
</Text>
<p>
<Text as="p" variant="bodyMd">
Interjambs are the rounded protruding bits of your puzzlie piece
</p>
</Text>
</AlphaStack>
</Box>
<AlphaCard roundedAbove="sm">
Expand Down