- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Rename Shape to Border and remove legacy border radius alias values #8304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| size-limit report 📦
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢✨💯 Only thought would be to include an entry in documentation/guides/migrating-from-v10-to-v11.md about this change as well.
| }: AlphaCardProps) => { | ||
| const breakpoints = useBreakpoints(); | ||
| const defaultBorderRadius = '2' as ShapeBorderRadiusScale; | ||
| const defaultBorderRadius = '2' as BorderRadiusScale; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const defaultBorderRadius = '2' as BorderRadiusScale; | |
| const defaultBorderRadius: BorderRadiusScale = '2'; | 
Also, can we move this value outside the body of the function?
| shapeBorderRadiusScale, | ||
| shapeBorderRadiusAlias, | ||
| } from '../../src/token-groups/shape'; | ||
| import {border, borderRadiusScale} from '../../src/token-groups/border'; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to rename the file as well
| /--p-border-radius-base/, | ||
| /--p-border-radius-large/, | ||
| /--p-border-radius-half/, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are removing these tokens won't they get flagged? Is this needed? Mentioning this to @aaronccasanova earlier and was just starting to chat about it. Following up on that convo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Removing these tokens is a bit weird to add them to the linter. The reason I think we should do this is to encourage people to use the latest version and use the tokens as intended. At some point in the future this can definitely be removed.
| 
 I'm working on documentation for removing tokens on another branch. If you follow this format below for the token removal portion of the documentation then it should avoid conflicts. No worries though if another way makes more sense! And I assume you'll also be creating another section talking about the token grouping rename so no worries if it breaks the format below.  | 
…adii-breaking-change
WHY are these changes introduced?
Border tokens are under a category called shape which is not clear to users. All of the values are categorised as
ShapeBorderso removingShapesimplifies this category. The tokens also have confusing legacy aliases which breaks the scale.WHAT is this pull request doing?
border-radius-baseborder-radius-largeborder-radius-halfborder-radius-baseborder-radius-largeandborder-radius-half