Skip to content

[Layout] Popover #7999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 30, 2023
Merged

[Layout] Popover #7999

merged 9 commits into from
Jan 30, 2023

Conversation

@aveline
Copy link
Contributor

@aveline aveline commented Jan 6, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes #7960

WHAT is this pull request doing?

Rebuild Popover with layout primitives

@github-actions github-actions bot added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023 •
edited
Loading

size-limit report 📦

Path Size
polaris-react-cjs 216.13 KB (+0.03% 🔺)
polaris-react-esm 137.47 KB (+0.04% 🔺)
polaris-react-esnext 191.21 KB (+0.01% 🔺)
polaris-react-css 40.67 KB (-0.08% 🔽)

@github-actions github-actions bot removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Jan 6, 2023
@aveline aveline marked this pull request as ready for review January 24, 2023 18:13
@aveline aveline self-assigned this Jan 24, 2023
laurkim
laurkim approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophatted chromatic against prod storybook and the Popover stories lgtm on all breakpoints 👍

@aveline aveline merged commit 0b144c2 into layout-rebuild-batch-3 Jan 30, 2023
@aveline aveline deleted the layout-popover branch January 30, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurkim laurkim laurkim approved these changes

@kyledurand kyledurand Awaiting requested review from kyledurand

+1 more reviewer

@chazdean chazdean chazdean approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aveline aveline

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aveline @laurkim @chazdean