Skip to content

Conversation

@aveline
Copy link
Contributor

@aveline aveline commented Nov 28, 2022

WHY are these changes introduced?

Fixes #7458

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@aveline aveline self-assigned this Nov 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

size-limit report 📦

Path Size
polaris-react-cjs 210.91 KB (+0.02% 🔺)
polaris-react-esm 136.13 KB (-0.04% 🔽)
polaris-react-esnext 191.27 KB (-0.11% 🔽)
polaris-react-css 41.59 KB (-0.36% 🔽)

@aveline
Copy link
Contributor Author

aveline commented Nov 30, 2022

The 3 Chromatic changes are not accurate. The snapshots don't match what is rendered in Storybook, either locally or in Chromatic. So leaving them as is.

@aveline aveline marked this pull request as ready for review November 30, 2022 19:10
@aveline aveline changed the title 🚧[WIP][Layout] Update ActionList to use Layout primitives [Layout] Update ActionList to use Layout primitives Nov 30, 2022
Copy link
Contributor

@laurkim laurkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Compared local storybook to existing production storybook and lgtm on all breakpoints 💯

@aveline aveline merged commit 6e6d97f into layout-rebuild-batch-2 Dec 1, 2022
@aveline aveline deleted the layout-action-list branch December 1, 2022 18:22
chazdean pushed a commit that referenced this pull request Dec 2, 2022
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim added a commit that referenced this pull request Dec 7, 2022
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim added a commit that referenced this pull request Dec 15, 2022
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
chazdean pushed a commit that referenced this pull request Jan 12, 2023
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
chazdean pushed a commit that referenced this pull request Jan 13, 2023
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
chazdean pushed a commit that referenced this pull request Jan 13, 2023
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim added a commit that referenced this pull request Jan 26, 2023
Fixes #7458

Co-authored-by: Lo Kim <lo.kim@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants