-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Layout] Update ActionList to use Layout primitives
#7805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Contributor
Author
|
The 3 Chromatic changes are not accurate. The snapshots don't match what is rendered in Storybook, either locally or in Chromatic. So leaving them as is. |
ActionList to use Layout primitivesActionList to use Layout primitives
laurkim
reviewed
Dec 1, 2022
laurkim
approved these changes
Dec 1, 2022
Contributor
laurkim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Compared local storybook to existing production storybook and lgtm on all breakpoints 💯
…tion.tsx Co-authored-by: Lo Kim <lo.kim@shopify.com>
… into layout-action-list
chazdean
pushed a commit
that referenced
this pull request
Dec 2, 2022
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim
added a commit
that referenced
this pull request
Dec 7, 2022
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim
added a commit
that referenced
this pull request
Dec 15, 2022
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
chazdean
pushed a commit
that referenced
this pull request
Jan 12, 2023
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
chazdean
pushed a commit
that referenced
this pull request
Jan 13, 2023
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
chazdean
pushed a commit
that referenced
this pull request
Jan 13, 2023
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
laurkim
added a commit
that referenced
this pull request
Jan 26, 2023
Fixes #7458 Co-authored-by: Lo Kim <lo.kim@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #7458
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes