Add stylelint metadata within shim #7541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesstelford
commented
Oct 27, 2022
| fixable: true, | ||
| }; | ||
|
|
||
| return convertStylelintRuleToPostcssProcessor(wrappedRule); |
There was a problem hiding this comment.
By splitting the shim out into its own function, the entire convertStylelintRuleToPostcssProcessor can be deleted once we're running on stylelint, and this simplified to:
- return convertStylelintRuleToPostcssProcessor(wrappedRule);
+ return wrappedRule;Without any changes to any of the migrations 🎉
jesstelford
commented
Oct 27, 2022
| } | ||
|
|
||
| export function createSassMigrator(name: string, ruleFn: PolarisMigrator) { | ||
| const wrappedRule = ruleFn as StylelintRule; |
There was a problem hiding this comment.
This gives us a logical point to inject further functionality (see the next PR where we also shim stylelint's report() method)
This was referenced Oct 27, 2022
jesstelford
force-pushed
the
createsassmigrator
branch
from
7886de6 to
e9271e4
Compare
jesstelford
force-pushed
the
stylelint-shim-meta
branch
from
ce3a751 to
03453e2
Compare
sam-b-rose
approved these changes
Oct 27, 2022
jesstelford
force-pushed
the
createsassmigrator
branch
2 times, most recently
from
f711b74 to
3723b68
Compare
jesstelford
force-pushed
the
stylelint-shim-meta
branch
from
03453e2 to
aab97db
Compare
Merged
laurkim
pushed a commit
that referenced
this pull request
Oct 28, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.7.0 ### Minor Changes - [#7499](#7499) [`85c0c3290`](85c0c32) Thanks [@jesstelford](https://github.com/jesstelford)! - Add `createSassMigrator` utility to stash common logic, starting with only parsing each event once. - [#7541](#7541) [`141746b5b`](141746b) Thanks [@jesstelford](https://github.com/jesstelford)! - Internally setup stylelint metadata for SASS migrations in preparation for switching to stylelint as our migration runner. ## @shopify/plugin-polaris@0.0.15 ### Patch Changes - Updated dependencies \[[`85c0c3290`](85c0c32), [`141746b5b`](141746b)]: - @shopify/polaris-migrator@0.7.0 ## @shopify/polaris@10.10.1 ### Patch Changes - [#7561](#7561) [`fc78fcc48`](fc78fcc) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix typo in box property, remove PropsWithChildren ## polaris-for-figma@0.0.28 ### Patch Changes - Updated dependencies \[[`fc78fcc48`](fc78fcc)]: - @shopify/polaris@10.10.1 ## polaris.shopify.com@0.23.3 ### Patch Changes - Updated dependencies \[[`fc78fcc48`](fc78fcc)]: - @shopify/polaris@10.10.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR belongs to a series of proposed changes:
createSassMigrator method to wrap common functionality #7499NOTE: This PR is best viewed with whitespace changes hidden
Stylelint rules require some metadata (name,
fixablemainly). This PR ensures that data is set, and also takes a best-guess at a URL for linking to rules directly from in-IDE prompts.