Skip to content

Bump storybook and add breakpoint viewports #7471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Bump storybook and add breakpoint viewports #7471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04755bb
Bump storybook and add breakpoint viewports
kyledurand Oct 20, 2022
4c0aa78
changeset
kyledurand Oct 20, 2022
952b432
re-write xs breakpoint
kyledurand Oct 21, 2022
5684cf5
Remove kebabToCamel func 💅
kyledurand Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-maps-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Added viewport addon to storybook and matched values to our breakpoints
6 changes: 5 additions & 1 deletion polaris-react/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ module.exports = {
files: '**/*.stories.tsx',
},
],
addons: ['@storybook/addon-a11y', '@storybook/addon-toolbars'],
addons: [
'@storybook/addon-a11y',
'@storybook/addon-toolbars',
'@storybook/addon-viewport',
],
webpackFinal: (config) => {
const extraRules = [
{
Expand Down
12 changes: 12 additions & 0 deletions polaris-react/.storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import enTranslations from '../locales/en.json';
import {GridOverlay} from './GridOverlay';
import {RenderPerformanceProfiler} from './RenderPerformanceProfiler';
import {gridOptions} from './manager';
import {breakpoints} from '@shopify/polaris-tokens';

function StrictModeDecorator(Story, context) {
const {strictMode} = context.globals;
Expand Down Expand Up @@ -79,6 +80,17 @@ export const globalTypes = {
},
...gridOptions,
};
const viewPorts = Object.entries({
...breakpoints,
'breakpoints-xs': '20rem', // Replace the 0px xs breakpoint with 320px (20rem) for testing small screens
}).map(([key, value]) => {
return {
name: key,
styles: {width: value, height: '100%'},
};
});

export const parameters = {viewport: {viewports: {...viewPorts}}};

export const decorators = [
GridOverlayDecorator,
Expand Down
11 changes: 6 additions & 5 deletions polaris-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,12 @@
"@shopify/postcss-plugin": "^5.0.1",
"@shopify/react-testing": "^4.1.0",
"@shopify/storybook-a11y-test": "1.0.1",
"@storybook/addon-a11y": "^6.5.9",
"@storybook/addon-toolbars": "^6.5.9",
"@storybook/builder-webpack5": "^6.5.9",
"@storybook/manager-webpack5": "^6.5.9",
"@storybook/react": "^6.5.9",
"@storybook/addon-a11y": "^6.5.12",
"@storybook/addon-toolbars": "^6.5.12",
"@storybook/addon-viewport": "^6.5.12",
"@storybook/builder-webpack5": "^6.5.12",
"@storybook/manager-webpack5": "^6.5.12",
"@storybook/react": "^6.5.12",
"@types/node": "^16.11.11",
"@types/react": "^18.0.15",
"@types/react-dom": "^18.0.6",
Expand Down
Loading