-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Data Table] Add zebra striping to table and change table density #5365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
size-limit report 📦
|
2e063fb to
32247c2
Compare
cf3598a to
8dc7b26
Compare
8dc7b26 to
d239cfb
Compare
d239cfb to
008e1da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates visually lgtm 👍 ❇️
008e1da to
f37f48e
Compare
f37f48e to
90ded40
Compare
53d2849 to
95f63b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
dc20f3b to
f640128
Compare
84515f8 to
c10717b
Compare
c10717b to
6a42482
Compare
bbb4dd9 to
b6ab89d
Compare
b6ab89d to
de4cb41
Compare
|
🎉 Thanks for your contribution to Polaris React! |
As you look at the examples below, you will see examples of this bug, related to the Card component. #5377I updated this PR to make the border radius of the table match the Card.WHY are these changes introduced?
(Ping @mirualves if you have UX questions)
WHAT is this pull request doing?
Density changes
This PR will reduce the padding around the cells to allow for a higher data density. It also aims to align with the visual changes and improvements coming soon to the Index Table component.
Zebra striping
This PR will update the data table to have the zebra striping where the first row is a dark colour and it alternates between that and the white colour for each subsequent row.
The alternating rows (zebra stripes) help users scan data more efficiently, especially for long horizontal datasets. The users may lose their place when parsing large datasets without alternating rows.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes