-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Closed
Description
Our repo and shopify/web is littered with migration comments to make stylelint happy. Many of them are no longer necessary as we removed layout from failures.
We should address this and make sure comments are added only when there is a failing next line (comments should not be needed for warnings). If a comment is added and not removed when an issue is fixed it should fail like eslint does.
- Create a new rule for stylelint that works like eslint-comments/no-unused-disable
- Add similar logic for
enable - Write a custom formatter or autofix to automate removal of these comments
- Ship the linting rule to
shopify/polarisand run formatter - Ship the linting rule to
shopify/weband run formatter
Alternate temporary approach
- Delete all polaris migrator injected comments
- Run migration again to add comments where it is needed
For example: #8644
Alternate approach
- Update the migration to add comments to also remove unused comments
Metadata
Metadata
Assignees
Labels
No labels