Skip to content

[Form Components] Bug: Combobox popover position not properly updated #7822

@LA1CH3

Description

@LA1CH3

Issue summary

In certain situations (for example, when rendered within a container with a dynamic height, such as a modal listing selected options that grows/shrinks in height), the popover position when using Combobox is not updated correctly and may cover the activator.

combobox-popover-position-bug.mp4

Seems similar to #4825

Expected behavior

Popover is able to update its position appropriate to the activator no matter the height of the surrounding container.

Actual behavior

Popover position does not update and covers the activator.

Steps to reproduce the problem

  1. Go to Shopify admin product details
  2. Click on "More filters".
  3. Click on "Tagged with".
  4. Observe popover covers text field.

Reduced test case

The best way to get your bug fixed is to provide a reduced test case. This CodeSandbox template is a great starting point.

Specifications

  • Are you using the React components? (Y/N): Y
  • Polaris version number: latest
  • Browser: Chrome
  • Device: M1 Macbook Pro
  • Operating System: Mac OS Ventura

Or run npx envinfo --system --binaries --browsers --npmPackages react,react-dom,@shopify/polaris to provide specifications on your environment including version numbers, browser, device, and operating system.

Paste the results here:

Metadata

Metadata

Labels

BugSomething is broken and not working as intended in the system.Component

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions