Merge pull request #13 from Shopify/prepare-ar-new-records

ActiveRecordCoder: handle `new_record` flag

CHANGELOG.md

@@ -0,0 +1,40 @@
+# Unreleased
+
+* Make ActiveRecordCoder handle to read payloads that will be generated by Paquito 0.7.0 (#12).
+  DO NOT upgrade to Paquito 0.7.0+ without first fully rolling out Paquito 0.6.2.
+
+# 0.6.1
+
+* No data
+
+# 0.6.0
+
+* No data
+
+# 0.5.0
+
+* No data
+
+# 0.4.0
+
+* No data
+
+# 0.3.1
+
+* No data
+
+# 0.3.0
+
+* No data
+
+# 0.2.1
+
+* No data
+
+# 0.2.0
+
+* No data
+
+# 0.1.0
+
+* No data

lib/paquito/active_record_coder.rb

@@ -4,6 +4,8 @@
 
 module Paquito
   class ActiveRecordCoder
+    EMPTY_HASH = {}.freeze
+
     class << self
       def dump(record)
         instances = InstanceTracker.new
@@ -94,13 +96,17 @@ def attributes_for_database(record)
         attributes
       end
 
-      def deserialize_record(class_name, attributes_from_database)
+      def deserialize_record(class_name, attributes_from_database, new_record = false)
         begin
           klass = Object.const_get(class_name)
         rescue NameError
           raise ClassMissingError, "undefined class: #{class_name}"
         end
-        klass.instantiate(attributes_from_database)
+
+        # Ideally we'd like to call `klass.instantiate`, however it doesn't allow to pass
+        # wether the record was persisted or not.
+        attributes = klass.attributes_builder.build_from_database(attributes_from_database, EMPTY_HASH)
+        klass.allocate.init_with_attributes(attributes, new_record)
       end
     end
 

test/activerecord/active_record_coder_test.rb

@@ -35,6 +35,20 @@ def setup
     assert_equal shop.products.first, recovered_value.products.first
   end
 
+  test "encodes wether the record was persisted or not" do
+    shop = Shop.find_by!(name: "Snow Devil")
+    assert_predicate shop, :persisted?
+    recovered_shop = @codec.load(@codec.dump(shop))
+    assert_predicate recovered_shop, :persisted?
+
+    new_shop = @codec.load([0, ["Shop", {}, true]])
+    refute_predicate new_shop, :persisted?
+
+    skip("Will pass on Paquito 0.7.0")
+    recovered_shop = @codec.load(@codec.dump(new_shop))
+    refute_predicate recovered_shop, :persisted?
+  end
+
   test "format is stable across payload commits" do
     shop = Shop.preload(:products).find_by!(name: "Snow Devil")