Add benchmark gem as a runtime dependency#445
Open
y-yagi wants to merge 1 commit intoShopify:mainfrom
Open
Conversation
Since Ruby 4.0.0, `benchmark` gem is not part of the default gems. We need to add that to use on Ruby 4.0+. Fixes: Shopify#444
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Allow to use
packwerkon Ruby 4.0.What approach did you choose and why?
Add
benchmarkgem as a runtime dependency this is because since Ruby 4.0.0,benchmarkgem is not part of the default gems. We need to add that to use on Ruby 4.0+.Fixes: #444
What should reviewers focus on?
Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist