Allow to configure parsers in packwerk (continued)#374
Closed
richardmarbach wants to merge 6 commits intoShopify:mainfrom
Closed
Allow to configure parsers in packwerk (continued)#374richardmarbach wants to merge 6 commits intoShopify:mainfrom
richardmarbach wants to merge 6 commits intoShopify:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Since no further development has taken place on #243, I hope it's ok that I've taken the liberty to implement the requested changes from #243 (comment)
What approach did you choose and why?
What should reviewers focus on?
This is the first time I've used minitest. Would love some feedback on if there's a better way to write the tests.
Type of Change
Additional Release Notes
Checklist