Omnibus cme tls #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metry#2) When uploading elf symbols, it is sometimes necessary to open a file other than the reported executalle (eg. to look for separate debug information).
This change makes systemProcess.Open return `/proc/<profiler_pid>/fd/<elf_fd>` as actual path instead of `/proc/<process_pid>/map_files/<mapping>`. The upside of this change is that the new path remains valid even after the target process has been terminated, while the old path becomes invalid.
* pass both go and gnu build ids
If a zero size is provided for the tracehandler cache, the cache will not be created.
* Avoid using the GITHUB_TOKEN for pr creation * fixing repo reference
…ookup in case of non-exported symbols to discover ractor/ec
Co-authored-by: Dale Hamel <dale.hamel@shopify.com> Co-authored-by: Manuel Correa <manuel.correa@shopify.com>
In Ruby 3.4.x, iseq_location_struct.pathobj can be an array [relative_path, absolute_path]. For some frames the absolute entry is an immediate (e.g., 0x4) rather than a Ruby RString. Original code always dereferenced index 1, then tried to read it as a string, producing “object at 0x00000004 is not a string,” which surfaced as unsymbolized frames (ffffffff...+0x0). Changed code so that, if pathobj is an array, inspect both entries and choose the one that is a Ruby string, preferring absolute when valid; otherwise relative.
…asing frame buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.