Add a update and delete methods to api and chat service #2
Conversation
RyanBrushett
force-pushed
the
add-update-and-delete-to-api
branch
from
7d80117 to
13cfa0e
Compare
lib/lita/adapters/slack/api.rb
Outdated
| end | ||
|
|
||
| def update_attachments(channel, ts, attachments) | ||
| call_api("chat.update", channel: channel, ts: ts, attachments: MultiJson.dump(attachments.map(&:to_hash))) |
RyanBrushett
force-pushed
the
add-update-and-delete-to-api
branch
from
13cfa0e to
ec67999
Compare
|
This PR brings the public fork of lita-slack up to spec with what the private fork had, tossing away some Shopify-specific changes (e.g. README shit) |
RyanBrushett
force-pushed
the
add-update-and-delete-to-api
branch
3 times, most recently
from
e11d6f8 to
088ff7b
Compare
| @@ -55,6 +55,14 @@ def send_attachments(room_or_user, attachments) | |||
| ) | |||
There was a problem hiding this comment.
You changed the permission of this file from 644 to 755
There was a problem hiding this comment.
😬 that was an accident! I'll fix that!
There was a problem hiding this comment.
Fixed! Thanks @rafaelfranca good eye.
RyanBrushett
force-pushed
the
add-update-and-delete-to-api
branch
2 times, most recently
from
f9f8a02 to
5d83664
Compare
|
@Shopify/operational-excellence Anyone have an opinion on this? I'd like to get it out, cut a release of it, and test it with our tools 🕵️♀️ |
lita-slack.gemspec
Outdated
| @@ -1,5 +1,5 @@ | |||
| Gem::Specification.new do |spec| | |||
| spec.name = "lita-slack" | |||
| spec.name = "shopify-lita-slack" | |||
| spec.version = "1.8.0" | |||
| spec.authors = ["Ken J.", "Jimmy Cuadra"] | |||
| spec.email = ["kenjij@gmail.com", "jimmy@jimmycuadra.com"] | |||
There was a problem hiding this comment.
I think the right thing to do is drop/change the spec author/email since we are publishing this spec under a different name. Code authorship will be clear via the git history
There was a problem hiding this comment.
I feel the same way. Okiedokie, I'll fix this up and we'll give it the ol' ⛵️
RyanBrushett
force-pushed
the
add-update-and-delete-to-api
branch
from
fa13d20 to
7cfdce5
Compare
|
(we also need to get CI working but ok for that to be a separate fix) |
RyanBrushett
force-pushed
the
add-update-and-delete-to-api
branch
from
7cfdce5 to
9f0f7a6
Compare
@ridwanmsharif @jarthorn @Shopify/operational-excellence