Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise syntax error from lexer parser with UTF-8 character #1839

Merged
merged 1 commit into from
Oct 30, 2024
Merged

raise syntax error from lexer parser with UTF-8 character #1839

merged 1 commit into from
Oct 30, 2024

Conversation

ggmichaelgo
Copy link
Contributor

With the new Lexer parser, we weren't capturing the entire UTF-8 character in the error message.

Example:

Lexer.new("1 < 1Ø").tokenize
Liquid syntax error: Unexpected character \xC3

@ggmichaelgo ggmichaelgo requested review from ianks, a team and Maaarcocr October 30, 2024 01:06
@ggmichaelgo ggmichaelgo changed the title raise syntax error from lexer parser with utf8 character raise syntax error from lexer parser with UTF-8 character Oct 30, 2024
@ggmichaelgo ggmichaelgo merged commit c626dfa into main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianks ianks ianks approved these changes

@Maaarcocr Maaarcocr Awaiting requested review from Maaarcocr Maaarcocr was automatically assigned from Shopify/liquid-perf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggmichaelgo @ianks