Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

fix gh action #488

Merged
merged 2 commits into from
Oct 14, 2022
Merged

fix gh action #488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659c02a
fix gh action
dani-santos-code Oct 6, 2022
3f2772b
also trigger action when issues are open
dani-santos-code Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/first-interaction.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
steps:
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: 'Thanks for opening your first issue here! Be sure to follow the issue template!'
pr-message: 'Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/Shopify/kubeaudit#Contributing) and [sign the CLA](https://cla.shopify.com/).'
name: Notify new contributors

on:
pull_request:
types:
- opened

jobs:
notify:
runs-on: ubuntu-latest
steps:
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: 'Thanks for opening your first issue here! Be sure to follow the issue template!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do we need to set issue-message when we're only triggered on pull_request.opened?

Maybe we could skip this? or maybe we should trigger on issues.opened as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! good point. I guess we want to do it for both PRs and Issues, since we have a message for each

I'll just confirm this and read up a bit more on the action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this helps a bit: https://github.com/actions/first-interaction/blob/main/.github/workflows/first-interaction.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! I like how we don't waste any time with a pointless actions/checkout like that example does!

pr-message: 'Thanks for opening this pull request! Please check out our [contributing guidelines](https://github.com/Shopify/kubeaudit#Contributing) and [sign the CLA](https://cla.shopify.com/).'