Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Removes mountds in favour of mounts #330

Closed
wants to merge 1 commit into from

Conversation

dani-santos-code
Copy link
Contributor

@dani-santos-code dani-santos-code commented Mar 23, 2021

Description

This PR removes mountds in favor of mounts which is an enhancement, since it checks not only for /var/run/docker.sock, but also other sensitive paths that are mounted, much like in Falco.

For more context, see #322

After this is merged, we can then release a new version of kubeaudit.
Fixes #328

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?
  • unit tests
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

Copy link
Contributor

@genevieveluyt genevieveluyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove it from the all command but keep the mountds command separately and add a deprecation notice to the docs and maybe even the terminal output if it's set to pretty format. Something like "mountds is deprecated and will stop working in the next version. Please use mounts instead." Wdyt?

@dani-santos-code
Copy link
Contributor Author

Oh, interesting point. I thought we just wanted to remove the command. But the idea of sending a warning first about the deprecation is definitely more subtle/considerate for the users. Thanks! 🙏🏽

@dani-santos-code
Copy link
Contributor Author

This will be done in another PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate mountds
2 participants