Fix duplicate results (#282)

cmd/commands/root.go

@@ -50,7 +50,7 @@ func init() {
 	RootCmd.PersistentFlags().StringVarP(&rootConfig.kubeConfig, "kubeconfig", "c", "", "Path to local Kubernetes config file. Only used in local mode (default is $HOME/.kube/config)")
 	RootCmd.PersistentFlags().StringVarP(&rootConfig.minSeverity, "minseverity", "m", "INFO", "Set the lowest severity level to report (one of \"ERROR\", \"WARN\", \"INFO\")")
 	RootCmd.PersistentFlags().BoolVarP(&rootConfig.json, "json", "j", false, "Output audit results in JSON")
-	RootCmd.PersistentFlags().StringVarP(&rootConfig.namespace, "namespace", "n", apiv1.NamespaceAll, "Only audit resources in the specified namespace. Only used in cluster mode.")
+	RootCmd.PersistentFlags().StringVarP(&rootConfig.namespace, "namespace", "n", apiv1.NamespaceAll, "Only audit resources in the specified namespace. Not currently supported in manifest mode.")
 	RootCmd.PersistentFlags().StringVarP(&rootConfig.manifest, "manifest", "f", "", "Path to the yaml configuration to audit. Only used in manifest mode.")
 }
 

internal/k8s/client.go

@@ -81,8 +81,6 @@ func IsRunningInCluster(client Client) bool {
 type ClientOptions struct {
 	// Namespace filters resources by namespace. Defaults to all namespaces.
 	Namespace string
-	// ExcludeGenerated filters out generated resources (eg. pods generated by deployments). Defaults to including generated resources.
-	ExcludeGenerated bool
 }
 
 // GetAllResources gets all supported resources from the cluster
@@ -117,13 +115,12 @@ func GetAllResources(clientset kubernetes.Interface, options ClientOptions) []k8
 		resources = append(resources, resource.DeepCopyObject())
 	}
 
-	if options.ExcludeGenerated {
-		resources = excludeGenerated(resources)
-	}
+	resources = excludeGenerated(resources)
 
 	return resources
 }
 
+// excludeGenerated filters out generated resources (eg. pods generated by deployments)
 func excludeGenerated(resources []k8stypes.Resource) []k8stypes.Resource {
 	var filteredResources []k8stypes.Resource
 	for _, resource := range resources {

internal/test/test.go

@@ -111,7 +111,7 @@ func GetReport(t *testing.T, fixtureDir, fixture string, auditables []kubeaudit.
 		defer deleteNamespace(t, namespace)
 		createNamespace(t, namespace)
 		applyManifest(t, fixture, namespace)
-		report, err = auditor.AuditLocal("", k8s.ClientOptions{Namespace: namespace, ExcludeGenerated: true})
+		report, err = auditor.AuditLocal("", k8s.ClientOptions{Namespace: namespace})
 	}
 
 	require.NoError(err)