Support conditional arguments in Sorbet compiler #593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #591
When generating types for
build_enumerator
definitions with both required positional arguments and other types of arguments:The compiler failed with:
Looking at the parameter types and indices, this becomes clear:
Because
RBI::ReqParam
is not inPARAM_TYPES_IN_ORDER
, its index in that list isnil
, and sorting it in a list with integers doesn't work. (The existing tests used either all mandatory positional arguments, or no mandatory positional arguments, so they didn't hit this case, and sorting a list with allnil
elements does work.)It turns out that
RBI::Param
is the superclass, and doesn't tend to occur as the concrete parameter type, so we can just replace it withRBI::ReqParam
to fix it.I also added some more test cases with optional parameters.