Add ESLint promise handling rules to prevent Cloudflare Workers errors #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added @typescript-eslint/no-floating-promises and @typescript-eslint/no-misused-promises rules to both the root eslint config and skeleton template. These rules help prevent "The script will never generate a response" errors when deploying to Oxygen/Cloudflare Workers by ensuring promises are properly handled. Reference: https://developers.cloudflare.com/workers/observability/errors/#the-script-will-never-generate-a-response-errors
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
rbshop
approved these changes
Sep 9, 2025
juanpprieto
approved these changes
Sep 9, 2025
This was referenced Sep 11, 2025
Closed
Merged
juanpprieto
pushed a commit
that referenced
this pull request
Sep 17, 2025
#3146) Added @typescript-eslint/no-floating-promises and @typescript-eslint/no-misused-promises rules to both the root eslint config and skeleton template. These rules help prevent "The script will never generate a response" errors when deploying to Oxygen/Cloudflare Workers by ensuring promises are properly handled. Reference: https://developers.cloudflare.com/workers/observability/errors/#the-script-will-never-generate-a-response-errors
5 tasks
This was referenced Sep 26, 2025
Add --version=next support to
upgrade command & improve upgrade e2e tests to validate 2025.7.0
#3221
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@typescript-eslint/no-floating-promisesand@typescript-eslint/no-misused-promisesESLint rulesWhy these changes?
Cloudflare recommends enabling these ESLint rules to catch promise handling issues that can cause runtime errors in Workers environments. When promises are not properly awaited or returned, Workers may terminate the script prematurely, leading to the dreaded "The script will never generate a response" error.
Reference: Cloudflare Workers Error Documentation
What's changed
eslint.config.js: Added the two promise rules to the TypeScript strict configuration for linted packageseslint.config.js: Added the same rules so new Hydrogen projects have these safeguards from the start