-
Notifications
You must be signed in to change notification settings - Fork 382
Add GraphQL @defer directive support to storefront client #2993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Add defer support by just checking if the query includes the `@defer` directive. If it does, use the shopify graphql client. Using this client is awkward though, because it doesn't expose the raw Resposne object. Perhaps we could refactor everything to use it? Also change the default `updateDiscountCodes` fragment to use the `@defer` fragment
fe342d4 to
75a5dd4
Compare
blittle
commented
Jun 23, 2025
This comment has been minimized.
This comment has been minimized.
juanpprieto
approved these changes
Jul 9, 2025
Contributor
juanpprieto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a good compromise, thanks!
Closed
juanpprieto
added a commit
that referenced
this pull request
Sep 17, 2025
* Add defer support Add defer support by just checking if the query includes the `@defer` directive. If it does, use the shopify graphql client. Using this client is awkward though, because it doesn't expose the raw Resposne object. Perhaps we could refactor everything to use it? Also change the default `updateDiscountCodes` fragment to use the `@defer` fragment * Delete defer test route * Add changeset --------- Co-authored-by: Juan P. Prieto <jp@calltheguys.co>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PoC support for
@deferin GraphQL queries. Hydrogen doesn't use@shopify/graphql-client, because we have a lot of custom caching and request tracking.@defersupport was implemented in@shopify/graphql-client, and it's not trivial. This PoC adds support by conditionally calling the@shopify/graphql-clientwhen we detect@deferis used. It's awkward though, because that client doesn't expose the rawResponseobject, so I have it overridingfetchjust to get at theResponseobject.Test it out by adding the following route:
EDIT
You can test out the new network discount codes, that require defer, by loading the demo store, adding something to the cart, and trying to apply the discount code:
NETWORK_CALL_DISCOUNT. It should take 1-2 seconds, and this discount code won't work on the main branch.Checklist