-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated --worker CLI flag #2603
Changes from 3 commits
18e3f6c
b881013
d8b1cf1
fc4331a
56bae64
d212fce
32d9f39
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@shopify/cli-hydrogen': patch | ||
--- | ||
|
||
Remove deprecated --worker and --env-branch cli flags |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,7 +72,6 @@ export default class Deploy extends Command { | |
static flags: any = { | ||
...commonFlags.entry, | ||
...commonFlags.env, | ||
...commonFlags.envBranch, | ||
...overrideFlag(commonFlags.envFile, { | ||
'env-file': { | ||
description: | ||
|
@@ -82,7 +81,7 @@ export default class Deploy extends Command { | |
}), | ||
preview: Flags.boolean({ | ||
description: | ||
'Deploys to the Preview environment. Overrides --env-branch and Git metadata.', | ||
'Deploys to the Preview environment. Overrides Git metadata.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This previously stated that it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes - remove
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've reverted the removal of the flag, but I think this update should remain as the code shows that this claim was false anyway |
||
required: false, | ||
default: false, | ||
}), | ||
|
@@ -197,7 +196,6 @@ interface OxygenDeploymentOptions { | |
buildCommand?: string; | ||
defaultEnvironment: boolean; | ||
env?: string; | ||
envBranch?: string; | ||
environmentFile?: string; | ||
force: boolean; | ||
noVerify: boolean; | ||
|
@@ -246,7 +244,6 @@ export async function runDeploy( | |
buildCommand, | ||
defaultEnvironment, | ||
env: envHandle, | ||
envBranch, | ||
environmentFile, | ||
force: forceOnUncommitedChanges, | ||
noVerify, | ||
|
@@ -357,10 +354,6 @@ export async function runDeploy( | |
); | ||
} | ||
|
||
if (isCI && envBranch) { | ||
rbshop marked this conversation as resolved.
Show resolved
Hide resolved
|
||
userProvidedEnvironmentTag = envBranch; | ||
} | ||
|
||
if (!isCI) { | ||
deploymentData = await getOxygenDeploymentData({ | ||
root, | ||
|
@@ -382,11 +375,6 @@ export async function runDeploy( | |
if (userProvidedEnvironmentTag === null) { | ||
isPreview = true; | ||
} | ||
} else if (envBranch) { | ||
userProvidedEnvironmentTag = findEnvironmentByBranchOrThrow( | ||
deploymentData.environments || [], | ||
envBranch, | ||
).branch; | ||
} | ||
} | ||
|
||
|
@@ -405,7 +393,6 @@ export async function runDeploy( | |
!isCI && | ||
!defaultEnvironment && | ||
!envHandle && | ||
!envBranch && | ||
deploymentData?.environments | ||
) { | ||
if (deploymentData.environments.length > 1) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frandiox Should this be a major bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically yes, but since we are releasing under the bundled global CLI, it doesn't matter much. It's not going to be a major bump in the bundled CLI yet, so feel free to do it in a minor here. It's also been announced as deprecated for very long so it's probably OK.