-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skeleton] Make cart banner optimistic #2502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another contribution @frontsideair! Subtle but important piece of the UX 🙌 Left a few comments.
Thanks for the review! I made the changes, except my note about |
@scottdixon can I ping you on this, if you have the bandwidth? Also for #2503 and #2506 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @frontsideair!
Left a couple of comments and ccing @wizardlyhel for a second set of eyes 🙏
@scottdixon thanks for the review, sent a fix just now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor issue - everything else looks good
WHY are these changes introduced?
While the cart sidebar is optimistic, the banner isn't, which is inconsistent
WHAT is this pull request doing?
It makes the cart banner count optimistic
HOW to test your changes?
Post-merge steps
Checklist