Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom .env files #2392

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Support custom .env files #2392

merged 3 commits into from
Aug 5, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Aug 2, 2024

Related: https://github.com/orgs/Shopify/projects/5093?pane=issue&itemId=71970801
Related: #2351

This allows passing --env-file .env.test to env:pull, dev and preview (deploy and env:push already supported it).
This means someone can pull multiple envs for different stores, and run dev separately with the same setup.

🎩 :

  1. h2 link
  2. h2 env pull --env-file .env.test
  3. h2 logout
  4. h2 dev should show mock.shop (no store domain in .env).
  5. h2 dev --env-file .env.test should show demo-store items.

@frandiox frandiox requested a review from a team August 2, 2024 13:51
Copy link
Contributor

shopify bot commented Aug 2, 2024

Oxygen deployed a preview of your fd-env-file-dev branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment August 2, 2024 1:51 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment August 2, 2024 1:51 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment August 2, 2024 1:51 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment August 2, 2024 1:51 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment August 2, 2024 1:51 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment August 2, 2024 1:51 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 looks good!

@juanpprieto juanpprieto merged commit c204eac into main Aug 5, 2024
13 checks passed
@juanpprieto juanpprieto deleted the fd-env-file-dev branch August 5, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants