Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a google cache check to hydration #2334

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add a google cache check to hydration #2334

merged 1 commit into from
Jul 30, 2024

Conversation

blittle
Copy link
Contributor

@blittle blittle commented Jul 15, 2024

WHY are these changes introduced?

Fixes #1502

WHAT is this pull request doing?

Prevent the page from hydrating when it's a google cache view. Hydration should not be necessary, and it causes an infinite reload.

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented Jul 15, 2024

Oxygen deployed a preview of your bl-hydration-check branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 15, 2024 9:46 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 15, 2024 9:46 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 15, 2024 9:46 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 15, 2024 9:46 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 15, 2024 9:46 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 15, 2024 9:47 PM

Learn more about Hydrogen's GitHub integration.

@blittle blittle merged commit 78bfde1 into main Jul 30, 2024
12 checks passed
@blittle blittle deleted the bl-hydration-check branch July 30, 2024 14:19
@eyesore-
Copy link

eyesore- commented Aug 9, 2024

@blittle @michenly Is it possible to change a changeset file retroactively? The release notes state it should be changed in entry.server.tsx instead of entry.client.tsx. I could be wrong though.

@teja-virgio
Copy link

@blittle @michenly Is it possible to change a changeset file retroactively? The release notes state it should be changed in entry.server.tsx instead of entry.client.tsx. I could be wrong though.

Yes.. it should be changed to entry.client.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while loading the page in google cached version
4 participants