-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update changlog and skeleton version #2080
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Let's deploy 2024.4.2 before merging this.
pausing this PR as our release version need to be re-think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Michelle. Just left a note for Fran to share his view on the additional deps. Otherwise, looks great.
docs/changelog.json
Outdated
"@shopify/cli-hydrogen": "^8.0.3", | ||
"@shopify/hydrogen": "2024.4.1", | ||
"@shopify/remix-oxygen": "^2.0.4", | ||
"graphql": "^16.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have not previously tracked any dependencies that are specific to the skeleton such as graphql
isbot
and such. Previously, we have only be tracking Hydrogen specific deps and Remix deps (which included typescript
at some point. Thoughts here @frandiox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, listing skeleton dependencies here is not needed. I'd say we don't include them for now and start adding them when we actually need (e.g. like we did with TS).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just so I know, whats the situation with TS in which it was added into the devDependencies going forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't remember wrong, it's because TS can make breaking changes in minor releases. And perhaps we started using a new feature released in Hydrogen so we had to bump the minimum version in user projects 🤔
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
68ef212
to
923ef74
Compare
9921d53
to
dd1fe1f
Compare
Changelog.json update for the last 3 releases
#1994 << 2024.4.1
#2052 << ignore, because the changes are revert in the release
#2060 << I consider this 2024.4.2 for the changelog
Fixes to changelog release v2024.4.0:
Added release v2024.4.1:
Added release v2024.4.2:
Update skeleton version to use calvar as well