Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changlog and skeleton version #2080

Merged
merged 4 commits into from
May 8, 2024
Merged

update changlog and skeleton version #2080

merged 4 commits into from
May 8, 2024

Conversation

michenly
Copy link
Contributor

@michenly michenly commented May 2, 2024

Changelog.json update for the last 3 releases

#1994 << 2024.4.1

#2052 << ignore, because the changes are revert in the release

#2060 << I consider this 2024.4.2 for the changelog


Fixes to changelog release v2024.4.0:

  1. Use the dependencies and devDependencies to match with the skeleton@1.0.8 packgae.json
  2. Update the hash & PR & commit to sync up (those were not the same)

Added release v2024.4.1:

  1. Use the dependencies and devDependencies to match with the skeleton@1.0.9 packgae.json
  2. List fixes from @shopify/hydrogen, @shopify/hydrogen-react and skeleton

Added release v2024.4.2:

  1. Use the dependencies and devDependencies to match with the skeleton@1.0.10 packgae.json
  2. List fixes from skeleton

Update skeleton version to use calvar as well

@michenly michenly requested a review from a team May 2, 2024 19:14
@michenly michenly self-assigned this May 2, 2024
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Let's deploy 2024.4.2 before merging this.

@michenly
Copy link
Contributor Author

michenly commented May 6, 2024

pausing this PR as our release version need to be re-think

Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michelle. Just left a note for Fran to share his view on the additional deps. Otherwise, looks great.

"@shopify/cli-hydrogen": "^8.0.3",
"@shopify/hydrogen": "2024.4.1",
"@shopify/remix-oxygen": "^2.0.4",
"graphql": "^16.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not previously tracked any dependencies that are specific to the skeleton such as graphql isbot and such. Previously, we have only be tracking Hydrogen specific deps and Remix deps (which included typescript at some point. Thoughts here @frandiox?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, listing skeleton dependencies here is not needed. I'd say we don't include them for now and start adding them when we actually need (e.g. like we did with TS).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so I know, whats the situation with TS in which it was added into the devDependencies going forward?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't remember wrong, it's because TS can make breaking changes in minor releases. And perhaps we started using a new feature released in Hydrogen so we had to bump the minimum version in user projects 🤔

docs/changelog.json Show resolved Hide resolved
Copy link
Contributor

shopify bot commented May 7, 2024

Oxygen deployed a preview of your mc-changelog-update branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 8, 2024 2:48 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 8, 2024 2:47 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 8, 2024 2:48 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 8, 2024 2:48 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 8, 2024 2:47 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 8, 2024 2:48 PM

Learn more about Hydrogen's GitHub integration.

docs/changelog.json Outdated Show resolved Hide resolved
@michenly michenly merged commit cc9b548 into main May 8, 2024
12 checks passed
@michenly michenly deleted the mc-changelog-update branch May 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants