Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Shell: Add newline in output alias block #1950

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

madmath
Copy link
Contributor

@madmath madmath commented Apr 8, 2024

WHY are these changes introduced?

I noticed when setting up the h2 alias that there's no newline added, which makes the next thing added go directly after our hydrogen alias, making both commands fail.

Here's me installing powerlevel10k after the h2 alias

WHAT is this pull request doing?

Thought I'd add a newline at the end of the zsh block.

@madmath madmath requested a review from frandiox April 8, 2024 12:54

This comment has been minimized.

Copy link
Contributor

shopify bot commented Apr 8, 2024

Oxygen deployed a preview of your fix/shell-rc-file branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 8, 2024 2:50 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment April 8, 2024 2:50 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 8, 2024 2:50 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment April 8, 2024 2:50 PM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment April 8, 2024 2:50 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment April 8, 2024 2:50 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frandiox frandiox merged commit ab0df5a into main Apr 8, 2024
13 checks passed
@frandiox frandiox deleted the fix/shell-rc-file branch April 8, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants